setting LC_ALL to it's current value during startup

From: Date: Tue, 18 May 2004 12:21:43 +0000
Subject: setting LC_ALL to it's current value during startup
Groups: php.internals 
Request: Send a blank email to internals+get-9936@lists.php.net to get a copy of this message
Hi all! Could somebody explain me why we're setting only LC_CTYPE to it's current value in main/main.c, line 1368 ? What is the reason to make all users to call setlocale() explicitly to set LC_ALL ? Of course, there can be some reasons I'm unaware of, but I'd like to propose following tiny patch: Index: main.c =================================================================== RCS file: /repository/php-src/main/main.c,v retrieving revision 1.601 diff -u -r1.601 main.c --- main.c 24 Mar 2004 13:33:26 -0000 1.601 +++ main.c 18 May 2004 12:14:12 -0000 @@ -1365,7 +1365,7 @@ PG(disable_classes) = NULL; #if HAVE_SETLOCALE - setlocale(LC_CTYPE, ""); + setlocale(LC_ALL, ""); #endif --- WBR, Antony Dovgal aka tony2001 tony2001@phpclub.net || antony@dovgal.com

« previous php.internals (#9936) next »