RE: [PHP-DEV] setting LC_ALL to it's current value during startup
| From: | Wez Furlong | Date: | Tue, 18 May 2004 12:55:18 +0000 |
| Subject: | RE: [PHP-DEV] setting LC_ALL to it's current value during startup | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-9938@lists.php.net to get a copy of this message | ||
Hey Antony,
This is most likely due to some issues with serialize/unserialize and floating
point numbers; we don't want the format to change with the locale, since it
should be independent.
Yes, it is a mess :)
--Wez.
> -----Original Message-----
> From: Antony Dovgal [mailto:tony2001@phpclub.net]
> Sent: 18 May 2004 13:22
> To: php-dev
> Subject: [PHP-DEV] setting LC_ALL to it's current value during startup
>
> Hi all!
>
> Could somebody explain me why we're setting only LC_CTYPE to
> it's current value in main/main.c, line 1368 ?
> What is the reason to make all users to call setlocale()
> explicitly to set LC_ALL ?
>
> Of course, there can be some reasons I'm unaware of, but I'd
> like to propose following tiny patch:
>
> Index: main.c
> ===================================================================
> RCS file: /repository/php-src/main/main.c,v
> retrieving revision 1.601
> diff -u -r1.601 main.c
> --- main.c 24 Mar 2004 13:33:26 -0000 1.601
> +++ main.c 18 May 2004 12:14:12 -0000
> @@ -1365,7 +1365,7 @@
> PG(disable_classes) = NULL;
>
> #if HAVE_SETLOCALE
> - setlocale(LC_CTYPE, "");
> + setlocale(LC_ALL, "");
> #endif
>
> ---
> WBR,
> Antony Dovgal aka tony2001
> tony2001@phpclub.net || antony@dovgal.com
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>