Re: [RFC] Add openssl_pkcs7_read and extend openssl_pkcs7_verify
| From: | Jakub Zelenka | Date: | Sun, 11 Jun 2017 17:45:18 +0000 |
| Subject: | Re: [RFC] Add openssl_pkcs7_read and extend openssl_pkcs7_verify | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-99494@lists.php.net to get a copy of this message | ||
Hi,
On Wed, Jun 7, 2017 at 1:54 PM, Jelle van der Waa <jelle@vdwaa.nl> wrote:
>
>
> Another thing I would want to work on is making the openssl_pkcs7_*
> functions in memory instead of file based. This would increase the
> security concerns since that means it won't save plaintext temporarily to
> file.
>
> An attempt for that has been made in a PR, but was closed. Is the PR on
> the right 'track' or can the current functions change to accept either a
> string or a filename? (I'm not 100% if PHP internals allow that) or if
> it's really wanted. [1]
>
> [1] https://github.com/php/php-src/pull/560
>
>
I think that it makes sense to add it. Just one correction to my comment in
that PR. It seems probably more consistent with reference as it like that
in *_export_to_file functions.
Probably best to create a PR and then send a new email (new thread) and
just wait a little bit ;)
Cheers
Jakub