RE: cvs: phpweb /include layout.inc /user css.php index.php
| From: | James Cox | Date: | Wed, 14 May 2003 18:01:46 +0000 |
| Subject: | RE: cvs: phpweb /include layout.inc /user css.php index.php | ||
| References: | 1 | Groups: | php.mirrors |
| Request: | Send a blank email to php-mirrors+get-17652@lists.php.net to get a copy of this message | ||
>
> OK, I flame you as you asked for it! What is the point in adding the
> user CSS info into all PHP pages top? How is that user based after all?
> Pages get cached, especially the index page. Just wait for the reports
> that German events are bold for Hungarian visitors... The whole point in
> adding that stuff into it's own file was to have a different data
> storage on the client site and so really user based content.
>
> As you simply rendered this stuff useless, it would be better to remove
> it...
>
> Why wasn't that cache max-min lifetime header modification
> satisfactory?????
we were making an extra apache request for _every_ page. even if it returns
304, we still made the hit. when we push 100-250 reqs per second, like we do
when we're real busy, then an extra request for each 'real' apache request
is just insane.
The code still works, it only includes the css style if the ip2country stuff
works out. we eat a bit on it being cached... but then again, it's in every
header, so it'll work as the user browses around...
if we get reports, investigate another method or ditch it, but i'm quite
confident that this works well enough now.
-- james