Re: Bug #25839: Problems reporting a bug.
| From: | Curt Zirzow | Date: | Sat, 11 Oct 2003 17:40:38 +0000 |
| Subject: | Re: Bug #25839: Problems reporting a bug. | ||
| References: | 1 | Groups: | php.mirrors |
| Request: | Send a blank email to php-mirrors+get-21480@lists.php.net to get a copy of this message | ||
> From: bugs at zirzow dot dyndns dot org
> Operating system:
> PHP version: Irrelevant
> PHP Bug Type: Website problem
> Bug description: Problems reporting a bug.
>
> Description:
> ------------
> On the confirmation of submiting a bug. If one of the possible related
> bugs that is listed contains an open html tag in the summary, The rest of
> the page doesn't load or will mangle the display.
Attached is a patch for report.php to fix this problem, I'm not sure if
I have karma to commit this, and have yet to use my cvs account. Is there
some documentation on 'I've got my cvs account, so now what?' type thing :)
Curt
--
"I used to think I was indecisive, but now I'm not so sure."
Index: report.php =================================================================== RCS file: /repository/php-bugs-web/report.php,v retrieving revision 1.42 diff -u -r1.42 report.php --- report.php 20 Sep 2003 17:51:22 -0000 1.42 +++ report.php 11 Oct 2003 17:23:38 -0000 @@ -89,7 +89,7 @@ $bug_url = "/bug.php?id=$row[id]&edit=2"; - echo "<tr><td colspan=\"2\"><a href=\"$bug_url\">Bug #" . $row['id'] . ": " . $row['sdesc'] . "</a></td></tr>"; + echo "<tr><td colspan=\"2\"><a href=\"$bug_url\">Bug #" . $row['id'] . ": " . htmlspecialchars($row['sdesc']) . "</a></td></tr>"; echo "<tr><td>" . $summary . "</td>"; echo "<td>" . nl2br($resolution) . "</td>";
Index: report.php =================================================================== RCS file: /repository/php-bugs-web/report.php,v retrieving revision 1.42 diff -u -r1.42 report.php --- report.php 20 Sep 2003 17:51:22 -0000 1.42 +++ report.php 11 Oct 2003 17:23:38 -0000 @@ -89,7 +89,7 @@ $bug_url = "/bug.php?id=$row[id]&edit=2"; - echo "<tr><td colspan=\"2\"><a href=\"$bug_url\">Bug #" . $row['id'] . ": " . $row['sdesc'] . "</a></td></tr>"; + echo "<tr><td colspan=\"2\"><a href=\"$bug_url\">Bug #" . $row['id'] . ": " . htmlspecialchars($row['sdesc']) . "</a></td></tr>"; echo "<tr><td>" . $summary . "</td>"; echo "<td>" . nl2br($resolution) . "</td>";