note 96951 added to function.fwrite

After having problems with fwrite() returning 0 in cases where one would fully expect a return value of false, I took a look at the source code for php's fwrite() itself. The function will only return false if you pass in invalid arguments. Any other error, just as a broken pipe or closed connection, will result in a return value of less than strlen($string), in most cases 0. Therefore, looping with repeated calls to fwrite() until the sum of number of bytes written equals the strlen() of the full value or expecting false on error will result in an infinite loop if the connection is lost. This means the example fwrite_stream() code from the docs, as well as all the "helper" functions posted by others in the comments are all broken. You *must* check for a return value of 0 and either abort immediately or track a maximum number of retries. Below is the example from the docs. This code is BAD, as a broken pipe will result in fwrite() infinitely looping with a return value of 0. Since the loop only breaks if fwrite() returns false or successfully writes all bytes, an infinite loop will occur on failure. <code> <?php // BROKEN function - infinite loop when fwrite() returns 0s function fwrite_stream($fp, $string) { for ($written = 0; $written < strlen($string); $written += $fwrite) { $fwrite = fwrite($fp, substr($string, $written)); if ($fwrite === false) { return $written; } } return $written; } ?> </code> ---- Server IP: 66.207.199.35 Probable Submitter: 69.70.125.250 ---- Manual Page -- http://www.php.net/manual/en/function.fwrite.php Edit -- https://master.php.net/note/edit/96951 Del: integrated -- https://master.php.net/note/delete/96951/integrated Del: useless -- https://master.php.net/note/delete/96951/useless Del: bad code -- https://master.php.net/note/delete/96951/bad+code Del: spam -- https://master.php.net/note/delete/96951/spam Del: non-english -- https://master.php.net/note/delete/96951/non-english Del: in docs -- https://master.php.net/note/delete/96951/in+docs Del: other reasons-- https://master.php.net/note/delete/96951 Reject -- https://master.php.net/note/reject/96951 Search -- https://master.php.net/manage/user-notes.php