note 101571 added to features.file-upload
| From: | Damien at osu1 dot php dot net | Date: | Sun, 26 Dec 2010 13:56:43 +0000 |
| Subject: | note 101571 added to features.file-upload | ||
| Groups: | php.notes | ||
| Request: | Send a blank email to php-notes+get-175209@lists.php.net to get a copy of this message | ||
To user Marcus down here:
I aknowledge the fact you're not using data validation and sanitizing, ok it's an admin
page, but you may still be running into serious problems if, for example, uploading an image found
somewhere on the net from some unkown locations which can have scripts in their header or be
malicious files disguised as safe ones.
Even if working locally, messing up is still a pain in the a**.
And a piece of advice from a user who learned A LOT from php.net and grew up his skills thanks to
all people sharing their scripts:
please consider sharing something UPDATED. I landed by chance on your upload script and when I saw
the date you entered it I was astonished.
HTTP_POST_FILES?? seriously? What if a beginner copy/pastes your script?
You wrote it in November 2010, no escuses for using such deprecated stuff!!
And also consider a logical separation on your script, remove those (also deprecated) html tags and
rely on styles for that instead.
Just my 2 cents.
----
Server IP: 69.147.83.197
Probable Submitter: 95.236.222.189
----
Manual Page -- http://www.php.net/manual/en/features.file-upload.php
Edit -- https://master.php.net/note/edit/101571
Del: integrated -- https://master.php.net/note/delete/101571/integrated
Del: useless -- https://master.php.net/note/delete/101571/useless
Del: bad code -- https://master.php.net/note/delete/101571/bad+code
Del: spam -- https://master.php.net/note/delete/101571/spam
Del: non-english -- https://master.php.net/note/delete/101571/non-english
Del: in docs -- https://master.php.net/note/delete/101571/in+docs
Del: other reasons-- https://master.php.net/note/delete/101571
Reject -- https://master.php.net/note/reject/101571
Search -- https://master.php.net/manage/user-notes.php