note 101571 deleted from features.file-upload by danbrown

From: Date: Mon, 27 Dec 2010 17:11:40 +0000
Subject: note 101571 deleted from features.file-upload by danbrown
References: 1  Groups: php.notes 
Request: Send a blank email to php-notes+get-175240@lists.php.net to get a copy of this message
Note Submitter: Damien ---- To user Marcus down here: I aknowledge the fact you're not using data validation and sanitizing, ok it's an admin page, but you may still be running into serious problems if, for example, uploading an image found somewhere on the net from some unkown locations which can have scripts in their header or be malicious files disguised as safe ones. Even if working locally, messing up is still a pain in the a**. And a piece of advice from a user who learned A LOT from php.net and grew up his skills thanks to all people sharing their scripts: please consider sharing something UPDATED. I landed by chance on your upload script and when I saw the date you entered it I was astonished. HTTP_POST_FILES?? seriously? What if a beginner copy/pastes your script? You wrote it in November 2010, no escuses for using such deprecated stuff!! And also consider a logical separation on your script, remove those (also deprecated) html tags and rely on styles for that instead. Just my 2 cents.

« previous php.notes (#175240) next »