Re: cvs: pear /Forum/lib/classes/db NNTPStandard.php
| From: | Tomas V.V.Cox | Date: | Tue, 30 Oct 2001 20:43:26 +0000 |
| Subject: | Re: cvs: pear /Forum/lib/classes/db NNTPStandard.php | ||
| References: | 1 | Groups: | php.pear.cvs |
| Request: | Send a blank email to pear-cvs+get-1208@lists.php.net to get a copy of this message | ||
Martin Jansen wrote:
>
> On Tue, 30 Oct 2001 17:10:06 +0100, Tomas V.V.Cox wrote:
>
> >On Tuesday 30 October 2001 14:00, Martin Jansen wrote:
> >> On Mon, 29 Oct 2001 21:23:19 -0000, Morgan Christiansson wrote:
> >> >+ */
> >> >+ if(!is_object($this->db)) {
> >> >+ require_once("Net_NNTP/NNTP.php");
> >> >+ $this->db = new Net_NNTP;
> >> >+ $this->db->connect("news.php.net");
> >> >+ $this->db->_debug = 1;
> >> >+ }
> >>
> >> This isn't compliant to the PEAR coding standards. Please have a look
> >> at http://pear.php.net/manual/standards.php
> >
> >The problem with the class in this point is that the original author of
> >the class hasn't followed the convention on functions naming.
>
> Not only the function naming is weired: The indendation looks
> somewhat crapy, no? :-)
>
Oops I was refering me to the pear/Net_NNTP class. About the Moog
interface to it.. yeah.. Moog please try to follow the standar :-)
Tomas V.V.Cox