Re: cvs: pear /Forum/lib/classes/db NNTPStandard.php

From: Date: Tue, 30 Oct 2001 22:09:42 +0000
Subject: Re: cvs: pear /Forum/lib/classes/db NNTPStandard.php
References: 1 2  Groups: php.pear.cvs 
Request: Send a blank email to pear-cvs+get-1209@lists.php.net to get a copy of this message
Martin Jansen wrote:
On Tue, 30 Oct 2001 17:10:06 +0100, Tomas V.V.Cox wrote:
On Tuesday 30 October 2001 14:00, Martin Jansen wrote:
On Mon, 29 Oct 2001 21:23:19 -0000, Morgan Christiansson wrote: 
+      */
+      if(!is_object($this->db)) {
+ require_once("Net_NNTP/NNTP.php"); + $this->db = new Net_NNTP; + $this->db->connect("news.php.net"); + $this->db->_debug = 1; 
+      }
This isn't compliant to the PEAR coding standards. Please have a look at http://pear.php.net/manual/standards.php
The problem with the class in this point is that the original author of the class hasn't followed the convention on functions naming.
Not only the function naming is weired: The indendation looks somewhat crapy, no? :-) - Martin
Sorry about the indentation, i wasn't at home so i just downloaded an emacs win32 i found cause i had nothing to do, didn't have time to mess around with configuring it too, if i would have then i wouldn't have had any time left for coding problably. =) I suppose i could have tried to set indentation by using spaces but every time i type a ; emacs indents it for me and in this case wrongly.

« previous php.pear.cvs (#1209) next »