Re: cvs: pear /File_Archive package.xml /File_Archive/Archive/Reader MimeList.php
| From: | Daniel Convissor | Date: | Tue, 22 Feb 2005 07:13:51 +0000 |
| Subject: | Re: cvs: pear /File_Archive package.xml /File_Archive/Archive/Reader MimeList.php | ||
| References: | 1 | Groups: | php.pear.cvs |
| Request: | Send a blank email to pear-cvs+get-29657@lists.php.net to get a copy of this message | ||
Hi Vincent:
On Tue, Feb 22, 2005 at 12:32:06AM -0000, Vincent Lascaux wrote:
> + switch($extension)
> + {
> + case '3dmf': return 'x-world/x-3dmf';
The number of coding standards mishaps you've committed in the past week
is tremendous. I'm at a loss for words, so let me ask some rhetorical
questions...
Does the location of the return match the coding standards?
Oh, and does the location of the brace match the coding standards?
How about the spacing between "switch" and the "("?
May I suggest that for any more code you write, go to the sample file in
the coding standards, then copy and paste the base example, then change
the variable names and values to do what you need?
--Dan
--
T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409