Re: cvs: pear /File_Archive package.xml /File_Archive/Archive/Reader MimeList.php

Daniel Convissor wrote:

Hi Vincent: On Tue, Feb 22, 2005 at 12:32:06AM -0000, Vincent Lascaux wrote:

+    switch($extension)
+    {
+    case '3dmf': return 'x-world/x-3dmf';

The number of coding standards mishaps you've committed in the past week is tremendous. I'm at a loss for words, so let me ask some rhetorical questions...

May I suggest that for any more code you write, go to the sample file in the coding standards, then copy and paste the base example, then change the variable names and values to do what you need?

Yes its a good idea to always make all code in CVS follow CS. However CVS is there for development not to manage finished code. Especially since this code was developed originally outside of PEAR its obvious that there may be CS violations. I prefer that Vincent puts his code in CVS quickly rather than him using sourceforge instead or getting into all sorts of trouble over not using a version management software until his code is clean. Also remember that Vincent is a PER n00b. So I think a few more gentle reminders would be in order before anyone really has reason to be annoyed. Aside from that I think its good that you are actually looking at commit mails Daniel. Now if you could just try to be slightly more polite or atleast not sacrastic (and instead be scientific) about it things would go even better. regards, Lukas