Re: cvs: pear /DB_Table package.xml /DB_Table/DB Table.php /DB_Table/DB/Table QuickForm.php

Couple of minor things - You may want to do small commits for each bug in the future. - For the switch case you should put an extra line after the break; + break; + default: // use addRule() for all other elements (personally I indent the cases once more, but I suspect the package doesnt do that, so you are probably right to follow the existing code.) You may want to consider reducing the indentation.. the commit had a foreach .....{ if ($something) { .... { stuff indented more.. } } else { continue; } } but doing the continue on the negative first, you reduce the indentation, make the code a little more readable. and sometimes make it faster... Regards Alan On Wed, 2005-08-17 at 15:24 +0000, Mark Wiesemann wrote: > wiesemann Wed Aug 17 11:24:33 2005 EDT > > Modified files: > /pear/DB_Table package.xml > /pear/DB_Table/DB Table.php > /pear/DB_Table/DB/Table QuickForm.php > Log: > - first PEAR commit from the new maintainer of DB_Table > - re-introduce feature request #4610: new "label" key for columns, > as an addition to the "qf_label" key for column header in > tabular formats > - feature request #4941: new "qf_label_append" key for columns that > will be displayed after (adv)checkbox QuickForm elements > - bugfix: QuickForm's date "element" is a group, therefore we have > to use addGroupRule() instead of addRule() for such elements; > this also fixes a bug with non-standard rules when only an error > message was given in the rule definition (missing $format param) > - feature request #5029: new "qf_filters" key for columns that > applies filters to DB_Table generated forms; with the new > $formFilters parameter in getForm() one can apply filters to all > form elements (thanks to ieure at php dot net) > > -- PEAR CVS Mailing List (http://pear.php.net/) To unsubscribe, visit: > http://www.php.net/unsub.php