Re: cvs: pear /DB_Table package.xml /DB_Table/DB Table.php /DB_Table/DB/Table QuickForm.php

Alan Knowles wrote: > - You may want to do small commits for each bug in the future. I would have done it this time but I had to wait for CVS karma and had changed the code because I wanted to test the changes. And it shouln't be a big problem here because every change listed in the commit message applied to other functions in the code. > For the switch case you should put an extra line after the break; > + break; > + default: // use addRule() for all other elements Okay, I will change it and commit it. > (personally I indent the cases once more, but I suspect the package > doesnt do that, so you are probably right to follow the existing code.) Personally I do this also but existing code and Coding Standards want it that way. > You may want to consider reducing the indentation.. the commit had a > foreach .....{ > if ($something) { > .... > { stuff indented more.. } > > } else { > continue; > } > } > > but doing the continue on the negative first, you reduce the > indentation, make the code a little more readable. and sometimes make it > faster... Right, good catch. Will change this also. Thanks for your comments. Mark