Re: [pear-webmaster] Re: [PEAR-CORE] Re: cvs: pearweb /public_html/trackback trackback-admin.php

On 10/24/05, Greg Beaver <greg@chiaraquartet.net> wrote: > Pierre wrote: > > On Fri, 21 Oct 2005 22:43:55 -0400 > > cellog@php.net (Greg Beaver) wrote: > > > > > >>1) if you haven't tested the code, don't commit it > >>2) if you can't test it, post a patch to pear-webmaster > >>3) if you've tested it, commit it > >>4) if it's obvious you haven't tested it, you get a warning. On the > >>second commit of obviously untested code, your cvs karma is revoked > >>for 4 weeks, minimum. > > > > > > For your information, it was < 1 day for both "problems" together (both > > were not critical for our infrastructure). The last change the problem > > reporters did blocked pearweb for 5 days, who needs to loose anything? > > > > Short version, move on unless you have something usefull to say. > > I've been unable to get a great internet connection, but now I have one, > so I will send a quick message. > > Pierre, I would like to point out that I said "test before committing" > which has nothing to do with register_globals. (Anatoly, are you > listening?) > > "committing" refers to CVS. I also replied to a CVS commit message. I > would like to point out this message from October 12, 2005 as an example > of a blatant commit without any testing whatsoever. I am referring to > commits of this nature [names and such removed to protect the guilty]: Demagogy, pollitics (or BS in short). I did this commit. Do you know _WHY_ I did it urgently? Any clue? Because some people thinks they can update PHP like they change their shirt, or change apache or any other part of the server. Yes I prepared and tested a fix for this problem (globals being ignored in 4.4 and some other apc), my mistake, some silly CS fixes right before commit and leave for an important meeting. So, and excuse my tone, shut up with that now and continue to work on something more usefull and constructive and spare me such pathetic ideas. --Pierre