Re: cvs: pear /Spreadsheet_Excel_Writer/Writer Parser.php

Hi Xavier: On Mon, Nov 07, 2005 at 11:26:14PM -0000, Xavier Noguer Gallego wrote: > xnoguer Mon Nov 7 18:26:14 2005 EDT > Modified files: > /pear/Spreadsheet_Excel_Writer/Writer Parser.php > Log: > - reversing cosmetic changes so comments are readable again ... snip ... > - } elseif (preg_match('/^\$?([A-Ia-i]?[A-Za-z])\$?(\d+)$/', $token)) { > - // match references like A1 or $A$1 > + } > + // match references like A1 or $A$1 > + elseif (preg_match('/^\$?([A-Ia-i]?[A-Za-z])\$?(\d+)$/',$token)) > + { ... many more like this snipped. The question of "readable" is in the eye of the beholder. To me, it is far less clear what the comment refers to. My personal preference aside, the changes made here contradict the PEAR coding standards. Please apply the patch in reverse. Thanks, --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y data intensive web and database programming http://www.AnalysisAndSolutions.com/ 4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409