Re: cvs: pear /Spreadsheet_Excel_Writer/Writer Parser.php

On 11/18/05, Daniel Convissor <danielc@analysisandsolutions.com> wrote: > Hi Xavier: > > On Fri, Nov 11, 2005 at 10:32:35PM -0300, xavier noguer wrote: > > I prefer my coments to be _together_ with the code they refer to. > > I understand your preference. At the same time, what really matters is > making things consistent and readable for the thousands of people who look > at the source code. Kind of like those transparent car factories? > > Why do the changes contradict coding standards? > > The control structures section of the CS says the following > > } > elseif (preg_match('/^\$?([A-Ia-i]?[A-Za-z])\$?(\d+)$/',$token)) > { > > should be like this: > > } elseif (preg_match('/^\$?([A-Ia-i]?[A-Za-z])\$?(\d+)$/',$token)) { Done in cvs. > While I thought there was something in the CS about where to put comments > regarding control structures, I see there is not. But all the PHP code > I've ever seen does it like this: > > } elseif (preg_match('/^\$?([A-Ia-i]?[A-Za-z])\$?(\d+)$/',$token)) { > // match references like A1 or $A$1 Seems appropriate... first do, then comment. > Thanks, > > --Dan > > -- > T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y > data intensive web and database programming > http://www.AnalysisAndSolutions.com/ > 4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409 >