Re: cvs: pear /Spreadsheet_Excel_Writer/Writer Worksheet.php
| From: | xavier noguer | Date: | Sat, 19 Nov 2005 13:45:25 +0000 |
| Subject: | Re: cvs: pear /Spreadsheet_Excel_Writer/Writer Worksheet.php | ||
| Groups: | php.pear.cvs | ||
| Request: | Send a blank email to pear-cvs+get-36374@lists.php.net to get a copy of this message | ||
Good thing we are not a religious sect... otherwise conventions would
be mandatory.
-----------
Hello Again Xavier:
On Sat, Nov 12, 2005 at 11:18:25PM -0000, Xavier Noguer Gallego wrote:
> Modified files:
> /pear/Spreadsheet_Excel_Writer/Writer Worksheet.php
>
> - $this->_append($header.$data.$str);
> + $this->_prepend($header.$data.$str);
...
> - $this->_append($header . $data . $str);
> + $this->_prepend($header . $data . $str);
> }
Noticed an inconsistency in the spacing between concatenations. The
convention in PEAR, though I don't think it's documented in the CS, is to
have spaces between them.
Yours pedantically,
--Dan