Re: Re: cvs: pear /Math_Derivative Derivative.php

My initial goal was to suggest to bring the package back in php4 compatible zone. Hannes Magnusson wrote:

On 2/17/06, bertrand Gugger <bertrand@toggg.com> wrote:

Hannes Magnusson wrote:

Whole lot of this commit has nothing todo with PHP4, please keep commit messages as clear and correct as possible :)

It is related to PHP4, the idea was colder's package does not really need php5, then as such, is welcome by the some "still" only php4 pear users. Consider mathematicians are almost poor (for the money).

Read the commit message again and read the commit it self. There are few changes there that have absolutly nothing to do with php4 compatability. yes,

as

-     * @see Math_Derivative::definedx()
+     * @see Math_Derivative::setVariableName()

-    // {{{ definedx([(string) $value])
+    // {{{ setVariableName([(string) $value])

-        $this->definedx($d);
+        $this->setVariableName($d);

-        $deepness = 0;
+        $depth = 0;

... and all the rest move $deepness to $depth

-                if (strlen($return_value) || $part == '-') {
+                if (strlen($return_value) || $part === '-') {

... what does not change nothing but a pico-performance better, dunno ...

-            if ($i&1) {
+            if ($i & 1) {

-                if ($i == $j || $j&1 || $otherPart === '1') {
+                if ($i === $j || $j & 1 || $otherPart === '1') {

-        if ($part == $this->_d) {
+        if ($part === $this->_d) {

... better CS

Was just a friendly note asking him to note *all* changes in the commit message in the future. This is no yet a released package,

I appreciate really Etienne's patience. Hannes, did you ever released a brand new package ? Myself, never :)

You all know my opinion on PEAR and PHP5 - but in this case it didn't have anything to do with anything. As long as PHP4 compatability doesnt restrain the package Im fine with it. Get an opinion about by who and how pear is used.

Do us some code, parsing a poor php4 compatible package giving "private", "static" and all those object stuff only as (required by pear) docbook indications so to transform the scripts in some "only php5" things.

Don't quite understand, do you what? Sorry, I asked you to do what.

-- toggg