PEAR:Date

(by mistake I originally posted this mail to pear-general) Hi, I am looking at using PEAR_Date and found a few things in the source that I want to ask about: How does Date handle I18N? I assume you atleast partly depend on setlocale()? I actually haven’t used setlocale() all that much, so I am just wondering if this is a reliable solution (since it does rely on correct settings outside of PHP etc.) So I guess what I mean is if it would make sense to have an alternative to setlocale(). // The constant telling us what day starts the week. Monday (1) is the // international standard. Redefine this to 0 if you want weeks to // begin on Sunday. define('DATE_CALC_BEGIN_WEEKDAY', 1); Is this constant really used in the entire application? Can't setlocale() handle this? Finally there are some whitespace issues on the files, as well as imho too many missing curly brackets. This I can quickly fix for you (actually I already have). Should I send you the patch or just commit? Regards, Lukas Smith smith@dybnet.de _______________________________ DybNet Internet Solutions GbR Reuchlinstr. 10-11 Gebäude 4 1.OG Raum 6 (4.1.6) 10553 Berlin Germany Tel. : +49 30 83 22 50 00 Fax : +49 30 83 22 50 07 www.dybnet.de info@dybnet.de