Best Practices: work with CVS (was Re: FW: execute and executeEmulatedQuery question)

yavor shahpasov wrote: > > > Name: oci8.diff > oci8.diff Type: unspecified type (application/octet-stream) > Encoding: quoted-printable I review your patch and send you some sugestions you may want to follow: - Follow the CODING_STANDARS doc (this is use 4 spaces instead of tabs, proper indents, braces, etc). - To send patches use "diff -u" instead of simply "diff" (more "human" friendly) - Give a brief description of the patch (it would help "commiters" to properly fill the log in the CVS) - ALWAYS build the patch against the last version from the CVS (your patch has been made against an older version of the extension). - ALWAYS do a syntax check before commit anything (not applied in this case). The highly recommend way of working with CVS is: # cvs update work in the extension # make test # php -l oci8.php # cvs diff oci8.php manually review the patch # cvs update if the file you were working on changes, you need to re-adapt your patch to the new version, and repeat the previous steps # cvs commit or alternative send the patch to pear-dev Perhaps this would serves to others, so I CC it to pear-dev. Tomas V.V.Cox