Re: XML_RPC (RPC.php)

Sorry to provide them one at a time, nut there is another bug related to not treating well the PHP4 NULL type, and in general to 'unknown types': ... 24c24 < // require_once "PEAR.php"; --- > require_once "PEAR.php"; 1093d1092 < global $XML_RPC_Boolean; 1124c1123 < ### $XML_RPC_val = false; # wrong, we must return an empty obj anyway --- > $XML_RPC_val = false; .... I explain them a bit: The first is commenting out the inclusion of PEAR.php, which is only for my needs, but anyway nothing from it it referenced. The second, <<global $XML_RPC_Boolean;>>, is the one I mentioned already, in the helper function XML_RPC_encode at line 1093 The third, always in the helper function XML_RPC_encode, at line 1123, in case the type is anything else (the NULL tyoe enters here, but anu other is the same), shouldn return a false, but an empty $XML_RPC_val, which is an XML_RPC_value object, anyway. SO I commented it. Giancarlo Stig S. Bakken wrote: > > giancarlo pinerolo wrote: > > > > There is a mistake in the helper class at > > /php4/pear/XML/RPC.php > > > > which look as based on version 1.b9 of the classes by Edd Dumbill, > > the definition of the boolean type is not made global in the function > > > > function XML_RPC_encode($php_val) > > > > so the additional test for boolean fails > > > > 1093d1092 > > < global $XML_RPC_Boolean; > > > > >