Re:[2] [PEAR-DEV] Fix for PEAR Cache_Container_db.php

Hi Lorenzo not a real problem with the sprintf removal. it's not even my style :) I don't use sprintf in my script, but the guy who wrote this script initially did it. Therefore I don't have a problem with not using sprintf, but I have a problem with changing too much in one run, if another guy has to review it... that's the whole issue. that's also the reason, why it's not very advised to mix whitespace fixes with code fixes (was not the case with your patch...) > I missed that, however IMHO you should do a check for each > possible point of failure, not just a catch-all solution at the end... > This way a faulty $res is not overwritten by the next one, and > the (right) error is revealed... you're right :) > Seems ok to me. > Again, sorry for the "sprintf()" change... I probably have done so > for performance issues, but I can't really say that my method is faster. > I really should have respected your style... hehe :) But I commited already your MDB Container (without any changes :) ). so long chregu -- nam...christian stocker adr...bremgartnerstr. 66, ch-8003 zurich pho...+41 1 451 6021 www...http://phant.ch/chregu mob...+41 76 561 8860 ema...chregu@phant.ch wor...+41 1 240 5670 gpg...0x5CE1DECB