Re:[2] [PEAR-DEV] Fix for PEAR Cache_Container_db.php

08/11/2002 15.47.24 > not a real problem with the sprintf removal. it's not even my style > :) I don't use sprintf in my script, but the guy who wrote this script > initially did it. Therefore I don't have a problem with not using > sprintf, but I have a problem with changing too much in one run, if > another guy has to review it... that's the whole issue. that's also > the reason, why it's not very advised to mix whitespace fixes with > code fixes (was not the case with your patch...) Now I remember why I did this: the fact is that I didn't make the changes on your script *directly*, I just copied my code from mdb.php and replaced all MDB calls with DB ones... I forgot this because even if I posted the fix only two days ago, I had done the mods many days before... doh! > > I missed that, however IMHO you should do a check for each > > possible point of failure, not just a catch-all solution at the end. > > .. This way a faulty $res is not overwritten by the next one, and > > the (right) error is revealed... > > you're right :) Mmmm... now that you make me think of it, also mdb.php has to be fixed on that... doh! ....I'll do that ASAP, as usual... :-) > But I commited already your MDB Container (without any changes :) ). Tnx a lot! Bye Lorenzo --- [Quipo ISP - Questa E-mail e' stata controllata dal programma Declude Virus] [Quipo ISP - This E-mail was scanned for viruses by Declude Virus]