Re: Patch (trying again) -- was Re: [PEAR-DEV] PEAR Coding Standards

OOPs, wrong incantation. The patch uses SMARTIRC_* constants, the one I *really* used was: :%s/\(\W\)\([_A-Z]\{4,}\)\(\W\)/\1SMARTIRC_\2\3/gc BTW, I noticed that you are using ereg() quite a bit in your code. In my informal tests preg_match() is faster, in particular if you need to loop a lot on data for parsing. --- "Jesus M. Castagnetto" <jcastagnetto@yahoo.com> wrote: > I sent a patch as plain text, but the mailing list server for pear-dev does > not > like bodies bigger than 30000 bytes, as you can see below: > > > --- From qmail -- > > Hi. This is the qmail-send program at pb1.pair.com. > I'm afraid I wasn't able to deliver your message to the following addresses. > This is a permanent error; I've given up. Sorry it didn't work out. > <pear-dev@lists.php.net>: > ezmlm-reject: fatal: Sorry, I don't accept messages larger than 30000 bytes > (#5.2.3) > ... > --- end --- > > I am attaching a gzipped version of the file, let me know I you get it. The > patch was created using the incantation (in vim): > > :%s/\(\W\)\([_A-Z]\{4,}\)\(\W\)/\1NET_SMARTIRC_\2\3/gc > > Used the 'c' switch to try to avoid clobbering the syslog and socket > constants. > > HTH > > > > > > ===== > --- Jesus M. Castagnetto (jcastagnetto@yahoo.com) > > Research: > http://metallo.scripps.edu/ > Personal: http://www.castagnetto.org/ > > __________________________________________________ > Do you Yahoo!? > Yahoo! Mail Plus - Powerful. Affordable. Sign up now. > http://mailplus.yahoo.com > ATTACHMENT part 2 application/x-unknown name=patch.gz > -- > PEAR Development Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php ===== --- Jesus M. Castagnetto (jcastagnetto@yahoo.com) Research: http://metallo.scripps.edu/ Personal: http://www.castagnetto.org/ __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com