Yapircl bug?
| From: | Mirco MEEBEY Bauer | Date: | Sat, 21 Dec 2002 19:53:34 +0000 |
| Subject: | Yapircl bug? | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-11787@lists.php.net to get a copy of this message | ||
This looks like a bug for me...
in _checkTimeout()
if ($secslastrx > $this->yaprefs_rxtimeout &&
$secslasttx > $this->yaprefs_rxtimeout) {
if lastreceived is higher than receivetimeout
and
if lasttransmit is higher than receivetimeout
I think what you want is this:
if ($secslastrx > $this->yaprefs_rxtimeout &&
$secslasttx > $this->yaprefs_txtimeout) {
if lastreceived is higher than receivetimeout
and
if lasttransmit is higher than transmittimeout
Mirco Bauer aka MEEBEY
TO: Geir
PS: I am reading your code for checking how you handle some critical things... while that I found this "bug?"...
I really love one idea, handling the reply codes by methods directly... thats very useful for doing the channel syncronising and do other important IRC handling like Ping/Pong... I think I will add that kinda reply handling, if it is ok with you... is it?