Re: Yapircl bug?

On Saturday 21 December 2002 20:53, Mirco MEEBEY Bauer wrote: > This looks like a bug for me... > > in _checkTimeout() > > if ($secslastrx > $this->yaprefs_rxtimeout && > $secslasttx > $this->yaprefs_rxtimeout) { > > if lastreceived is higher than receivetimeout > and > if lasttransmit is higher than receivetimeout > > > I think what you want is this: > > if ($secslastrx > $this->yaprefs_rxtimeout && > $secslasttx > $this->yaprefs_txtimeout) { > > if lastreceived is higher than receivetimeout > and > if lasttransmit is higher than transmittimeout Yeah thanks, that was lazy. I made this another variable now, but it works exactly the same because both variables are initialized to the same, but now the user gets to choose different values for both if they want to. http://projects.gtk.mine.nu/archive/yapircl/yapircl-0.5.8.tar.gz http://home.online.no/~geir37/archive/yapircl/yapircl-0.5.8.tar.gz (mirror) > > Mirco Bauer aka MEEBEY > > TO: Geir > > PS: I am reading your code for checking how you handle some critical > things... while that I found this "bug?"... > > I really love one idea, handling the reply codes by methods directly... > thats very useful for doing the channel syncronising and do other > important IRC handling like Ping/Pong... I think I will add that kinda > reply handling, if it is ok with you... is it? Well, I took that idea from Net_IRC and besides I couldn't have prevented you even if I had wanted to :) -- Geir Torstein Kristiansen web: http://projects.gtk.mine.nu