Re: File_Find patch

> On Sat, Dec 28, 2002 at 03:11:42PM +0530, Chandrashekhar Bhosle wrote: > > There's also a small whitespace bug here: > > > - while ($entry = @readdir ($dh)) { > > + while (false !== ($entry = @readdir ($dh)) { > ^ > There should be no space before the opening parenthesis. This would > make it consistent with the accepted style as well as the style used > later on in this file, as evidenced here: > > > + while (false !== ($entry = readdir($dh)) { > > [...] > > > + while (false !== ($entry = @readdir($dh)) { > err, that's more leftovers, the first was written before the pear style guidelines, the latter afterwards. If it offends your senses, feel free to change it ;-) -Sterling > -- > Jon Parise (jon@php.net) :: The PHP Project (http://www.php.net/)