Re: SMTP AUTH CRAM-MD5 and Debug Method

Perfect! With this patches commited, I can make the LMTP class But, because LMTP is based on ESMTP this class should be 99% equal to SMTP. (only changes the VERBS (for example instead of write EHLO to read the server's capabilitys, you write LHLO and so on) I think we can use the Net_SMTP existing code as base to build a base class that Net_SMTP and Net_LMTP could use. What do you think? If you agree I can have a prototype by tomorrow of the 3 classes (Net_SMTP, Net_LMTP and the "new" base class) On Tue, 2003-01-14 at 01:34, Jon Parise wrote: > On Tue, Jan 14, 2003 at 12:53:59AM -0300, Damian Alejandro Fernandez Sosa wrote: > > > I'll send you the Digest-MD5 patch using Richard Heyes's > > (richard@php.net) Auth_SASL class > > > > This Patch adds a dependency on Net_SMTP but we have the Auth code in > > only one place. (the Auth_SASL class) > > Committed (with the dependency registered in package.xml). > > > Also I send you a patch to implement the CRAM-MD5 via Richard's > > excellent work. > > Also committed. > > > Please commit those changes if you accept to have other dependency. > > I think the dependency is worthwhile (I dislike code duplication). > However, Net_SMTP is listed as one of the preferred packages by > go-pear, so Auth_SASL will also be required to install that set of > packages. > > I've Cc:'ed Tomas and Stig to make sure they're aware of this > dependency as they're listed as the authors of go-pear.