Re: Cache_Lite patch
| From: | Fabien MARTY | Date: | Tue, 14 Jan 2003 17:36:15 +0000 |
| Subject: | Re: Cache_Lite patch | ||
| References: | 1 2 3 4 5 6 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-12417@lists.php.net to get a copy of this message | ||
Le mar 14/01/2003 à 16:33, Jon Parise a écrit :
> On Tue, Jan 14, 2003 at 04:30:11PM +0100, Pierre-Alain Joye wrote:
>
> > I remember weird behiavors with older php versions, isset() && ==""
> > solved them. Anyway, imho, the best practice is to initialize the
> > variable :') as usual.
>
> Yes, I definitely agree. I would still like to see empty() used in
> the final code, though.
>
> if (!empty($data) && $this->_memoryCaching) {
First, thanks to Lorenzo for the report and the patch and to Jon and PA
for the thread. But, as suggested, IMHO, it would be better simply to
add :
$data = false;
at the beginning of the method :-)
If no problem with it, i will commit it tonight,
Fab