Re: Cache_Lite patch

> Le mar 14/01/2003 à 16:33, Jon Parise a écrit : > > On Tue, Jan 14, 2003 at 04:30:11PM +0100, Pierre-Alain Joye wrote: > > > > > I remember weird behiavors with older php versions, isset() && > > > =="" solved them. Anyway, imho, the best practice is to > > > initialize the variable :') as usual. > > > > Yes, I definitely agree. I would still like to see empty() used in > > the final code, though. > > > > if (!empty($data) && $this->_memoryCaching) { > > First, thanks to Lorenzo for the report and the patch and to Jon and > PA for the thread. But, as suggested, IMHO, it would be better simply > to add : > $data = false; > at the beginning of the method :-) > If no problem with it, i will commit it tonight, > Fab Oh, my! I posted this patch this morning, I come home now and see all these replies! Didn't want to start such a long thread, it was just a quick'n'dirty patch to suppress a NOTICE... :-D :-D Anyway, I don't know which method is the best one, but I do agree that a variable inizialization would be better than anything else.... :-) Bye Lorenzo