RE: [PEAR-DEV] CS changes for PHP5? was Re: [PEAR-CVS] cvs: pear(ZEND_ENGINE_2) /XML_Transformer

> -----Original Message----- > From: Martin Jansen [mailto:mj@php.net] > Sent: Sunday, January 19, 2003 11:31 AM > To: Alan Knowles > Cc: pear-dev > Subject: Re: [PEAR-DEV] CS changes for PHP5? was Re: [PEAR-CVS] cvs: > pear(ZEND_ENGINE_2) /XML_Transformer > > On Sun Jan 19, 2003 at 11:2701AM +0800, Alan Knowles wrote: > > > > > > > > >- var $_caseFoldingTo = CASE_UPPER; > > >+ private $caseFoldingTo = CASE_UPPER; > > > > > > > > > > > Interesting dropping the $_ prefix on privates.. - while it is a little > > throwback to PHP4 not having real privates, it did have heratige in the > > hungerian (or whatever it's called) naming strategy.. - and does enhance > > program readiblity... > > > > Is the plan to drop this bit of the code standards for PHP5? (I for one > > would miss it :) > > I'm definitively for keeping it. Even with the "private" > keyword in front, the underscore improves readability a > lot. Me too. Sebastian is really pushing us to make some decisions towards how PEAR should deal with Zend2/PHP5. I remember that Stig wasn't all too happy with Sebastians approach to branch off the Zend2/PHP5 developments from the Zend1/PHP4 code either. But then again no alternative was offered. So either we will have to sit and watch Sebastian making precedents or we have to offer alternatives. Because what he is doing is certainly for the better of PHP future (test early). Regards, Lukas