Re: Upload class 0.6

le 10/08/01 16:27, Tomas V.V.Cox à cox@idecnet.com a écrit : > Do you think is good also for Pear? It looks globally OK for me. My concerns : nameToSafe is not Mac OS compliant (and probably not Windows compliant neither). On a Mac, filenames are 32 chars max. I would count 3 chars max for the extensions. That would make 28 chars max for the name (plus the dot). isUpload is not a really explicit name. Maybe isCorrectUpload or just isError would be enough. Error management in different languages is a bit difficult to use. You may have two solutions : first, you could let users override your error class with their own language or you can return only error codes which they will have to describe in globals for example. What I mean is that you shouldn't expect users to go look into their /usr/lib/php/pear directory to add their own error sentences. IMO. Apart from that, I don't see why it shouldn't be in PEAR. Thanks Bertrand Mansion Mamasam