Re: Upload class 0.6

At 16:27 2001-08-10 +0200, you wrote:

Hi, I've recently "upload" a new release of the Uploader Class. Changelog for the previous release: - Better error reporting - i18n support for error messages - added a new user error check: $file->isError() - more safe checks and E_ALL fixes I know that manage uploads for most people is enough to use php is_upload() and move_uploaded_file() functions, but if you need complex uploads, are tired of hacker break attemps, want to have check methods for user actions or want to get usefull and extensive information about the uploaded files, IMHO this class fills that hole. Do you think is good also for Pear?

It looks alright, but in Upload_Error you do:

        $this->lang = $lang;

without $this->lang being declared in the class. I think it is bad practice to use variables in a class which haven't been declared by var $var;. It can lead to no limit of bugs as well as make it harder for people to understand the logic of the class. /erik hjortsberg