Re: Re-Proposing Package: Console_phpman instead of PHP_phpi
| From: | Alan Knowles | Date: | Mon, 05 May 2003 11:15:02 +0000 |
| Subject: | Re: Re-Proposing Package: Console_phpman instead of PHP_phpi | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-15877@lists.php.net to get a copy of this message | ||
Stefan Walk wrote:
On Mon, May 05, 2003 at 08:30:21AM +0800, Alan Knowles wrote:I'd suggest include them as Console_PhpMan_Download, |Console_PHPMan_ProgressBar for the time being. The ProgresBar one sounds like a good little package. for HTTP_Download - can that be merged into the existing HTTP or Curl classes? Regards Alan |+1 here, few CS fixes - quite a few methods in Console_phpman are still this_is_the_method, rather than thisIsTheMethod. class should really be Ucfirst = Console_Phpman or Console_PhpMan .. you should break up the lib into seperate files for each class. an ini file or config package compatible 'config file' would be nice .. Otherwise looks great.. Regards AlanOkay, i renamed the functions and class, split the file up and use an ini file now for configuration. Source isn't up yet, i have to test it yet. I think i will propose the other classes as own packages, if they don't get accepted, how should i name the files? And should i rename the classes too? 'pear package' notes that they aren't prefixed with the package name.
Stefan-- Can you help out? Need Consulting Services or Know of a Job? http://www.akbkhome.com