Re: [PATCH] DB::connect(): stuff that should be in DB::factory()

# cox@idecnet.com / 2003-06-03 14:27:05 +0200: > From: "Roman Neuhauser" <neuhauser@bellavista.cz> > Subject: [PEAR-DEV] [PATCH] DB::connect(): stuff that should be in DB::factory() > > > DB::connect() uses DB::factory() to instantiate the appropriate > > class. > > > > Body of factory() was replaced with instantiation code from > > connect() (better error message, etc). > > > > factory() now takes two arguments, the second being $options > > (passed through from connect()); it's used just as it used to be in > > connect(). > > DB::factory() was nice for me to test parseDSN() ... but appart of it, why > would DB need to provide factory()? well, that's not for me to judge as I don't know all the ways people use PEAR::DB. but the code is there, and it should be either maintained or removed. letting it bitrot is not a good idea. -- If you cc me or remove the list(s) completely I'll most likely ignore your message. see http://www.eyrie.org./~eagle/faqs/questions.html