Re: [PATCH] DB::connect(): stuff that should be in DB::factory()

# smith@backendmedia.com / 2003-09-21 22:34:45 +0200: > > From: Roman Neuhauser [mailto:neuhauser@bellavista.cz] > > Sent: Sunday, September 21, 2003 10:30 PM > > # neuhauser@bellavista.cz / 2003-06-03 15:14:05 +0200: > > > # cox@idecnet.com / 2003-06-03 14:27:05 +0200: > > > > DB::factory() was nice for me to test parseDSN() ... but appart > > > > of it, why would DB need to provide factory()? > > > > > > well, that's not for me to judge as I don't know all the ways > > > people use PEAR::DB. but the code is there, and it should be > > > either maintained or removed. letting it bitrot is not a good > > > idea. > > > > There's grown such a need since then: a team I am a member of uses > > subclasses of the DB class, and some of its drivers. The DB subclass > > basically just redefines the DB::connect() method, and the gist of > > the change is that first looks for the driver in a custom directory > > before falling back on the default driver implementation. ~10 lines > > added, ~40 copied. The code duplication could have been reduced > > hadn't the factory method been left to bitrot. > > Please open a bug report. > And if Tomas finds the time he will attend to the issues and make a > decision. done: http://pear.php.net/bugs/bug.php?id=25 -- If you cc me or remove the list(s) completely I'll most likely ignore your message. see http://www.eyrie.org./~eagle/faqs/questions.html