Re: [PATCH] DB::oci8::fetchRow() should use fetchInto()
| From: | Roman Neuhauser | Date: | Tue, 10 Jun 2003 14:01:46 +0000 |
| Subject: | Re: [PATCH] DB::oci8::fetchRow() should use fetchInto() | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-17259@lists.php.net to get a copy of this message | ||
# neuhauser@bellavista.cz / 2003-06-10 13:57:24 +0200:
> DB::oci8::fetchRow() standardized (calls fetchInto() instead of
> a half-assed reimplementation of what that method does)
>
>
> ------------------------------------------------------------------------
> Index: DB/oci8.php
> ===================================================================
> --- DB/oci8.php (revision 4)
> +++ DB/oci8.php (revision 5)
> @@ -195,15 +195,11 @@
> if ($fetchmode == DB_FETCHMODE_DEFAULT) {
> $fetchmode = $this->fetchmode;
> }
> - if ($fetchmode & DB_FETCHMODE_ASSOC) {
> - $moredata = @OCIFetchInto($result, $row, OCI_ASSOC + OCI_RETURN_NULLS +
> OCI_RETURN_LOBS);
> - } else {
> - $moredata = @OCIFetchInto($result, $row, OCI_RETURN_NULLS + OCI_RETURN_LOBS);
> + $res = $this->fetchInto ($result, $arr, $fetchmode, $rownum);
^^^^^^^
erm, either this should've been null or fetchRow() would need to
grow third parameter, $rownum = null.
--
If you cc me or remove the list(s) completely I'll most likely ignore
your message. see http://www.eyrie.org./~eagle/faqs/questions.html