Re: [PATCH] DB::oci8::fetchRow() should use fetchInto()
| From: | Tomas V.V.Cox | Date: | Tue, 10 Jun 2003 17:05:10 +0000 |
| Subject: | Re: [PATCH] DB::oci8::fetchRow() should use fetchInto() | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-17269@lists.php.net to get a copy of this message | ||
----- Original Message -----
From: "Roman Neuhauser" <neuhauser@bellavista.cz>
To: <pear-dev@lists.php.net>
Sent: Tuesday, June 10, 2003 6:52 PM
Subject: Re: [PEAR-DEV] [PATCH] DB::oci8::fetchRow() should use fetchInto()
> # cox@idecnet.com / 2003-06-10 18:42:58 +0200:
> > From: "Roman Neuhauser" <neuhauser@bellavista.cz>
> > > see attached patch
> > >
> > > Tomas, since you're listed as a maintainer, could you please review,
> > > test, and eventually commit this patch? It so happens that it fixes a
> > > minor issue: fetchInto() lowercases the column names if told so by the
> > > $options array, but fetchRow() never does.
> > >
> > > The line numbers might be slightly off (I have other changes in this
> > > driver not submitted yet), but should apply cleanly.
> >
> > As I said in my previous email, oci::fetchRow() should just be dropped.
The
> > DB_result::fetchRow() calls internally fetchInto(), so this func gets
never
> > called.
>
> I have another question, then: why fetchInto(), when passing arrays
> by reference is (excuse me) slow as hell?
Did you bench it or have some tests to demostrate that?
Tomas V.V.Cox