Re: about realease 2.0 beta 3 of HTML_Page package
| From: | Laurent Laville | Date: | Mon, 14 Jul 2003 13:39:46 +0000 |
| Subject: | Re: about realease 2.0 beta 3 of HTML_Page package | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-18234@lists.php.net to get a copy of this message | ||
re-Hi Klaus,
First of all, thanks for links you gave me: i've learned again a lot !
> Check the latest CVS version and let me know if it works for you. Also,
> please let me know if you find any other bugs.
>
Second: i've checked your CVS version, and it seems to run fine except that,
if i'm a bad boy
i could write
$p->setMimeEncoding( 'TEXT/HTML' );
instead of
$p->setMimeEncoding( 'text/html' );
and my example won't run again. I suggest you to write lines 439 and 468 as
below :
if ( strtolower($this->_mime) == 'text/html' ) {
and not as in cvs version
if ($this->_mime == 'text/html' ) {
BTW, i've a new proposal / idea :
Could you add as a new feature a function to add easely inline javascript
code :
until now i should have to code :
$p->addBodyContent('<script type="text/javascript">');
$p->addBodyContent('var wexit =
"'.$this->_parent->getMessage('ExitSetupMessage').'";');
$p->addBodyContent('</script>');
because i can't put it in an outline script : the wexit js variable can be
different if i've a french or english user
I've thought something like :
function addScriptDeclaration($content, $type = 'text/javascript')
{
$this->_script[$type] =& $content;
}
note: have in mind to fix also the comment at line 648
* @param string $url URL to the linked style sheet
it 's a bad cut/paste from line 659; here (648) it's no more a stylesheet
but a javascript !
Well i think it's all for now .
Keep up the good work Klaus :o)
Laurent