Re: [dev] Horde_Cipher et al;

Mike Cochrane wrote:

----- Message from davey@php.net ---------

The code is fine. What's needed is to identify any Horde dependencies and to

get

them submitted to PEAR. I'd be very reluctant to submit them as seperate libraries, instead of as

the

whole Cipher/Crypt packages.

The reason for this is that there is existing Crypt_* packages, and putting this into PEAR as-is would break that sort of, in that the existing packages are stand-alone and these are not. :Like I said, I like the idea of having it all in one, but it just doesn't fit into PEAR like that. I will bring this up on the pear-dev ML and see what they think should be done.

I would not support it if the Horde_Cipher class was split into seperate packages. I am talking about standalone version of each driver along the lines of Crypt_RC4

The classes were never designed to work that way. Without the blockmode classes the cipher classes are useless and vice-vera. You need both to be able to do anything usefull. Then in the light of this, we have a choice of code duplication or keeping this as one package. (or perhaps a Crypt_Base class (or something like this) which contains this stuff for all of the encryption stand-alone packages to use? sounds like a good idea to me actually...)

Horde_Cipher currently depends on Crypt_Rc4 for RC4 encryption. Horde_Cipher would obsolete Crypt_Crypt (never released) and Crypt_CBC. Oh? Horde_Cipher uses the PEARs Crypt_RC4? Didn't look like that in CVS. I've proposed to replace to Crypt_Crypt with two packages Crypt_Cipher which would be Horde_Cipher (with support for the other Crypt_* encryption packages it doesn't currently support) and a Crypt_Hash which would be a similar package but for the hashing Crypt_* packages only. I am not entirely sure what CBC is, why does Horde_Cipher replace it?

- Mike :-)

- Davey