Re: Mail/mime.php changes
| From: | Martin Jansen | Date: | Sun, 16 Sep 2001 17:34:21 +0000 |
| Subject: | Re: Mail/mime.php changes | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-1951@lists.php.net to get a copy of this message | ||
On Sun, 16 Sep 2001 13:29:04 -0400, Jon Parise wrote:
>> '--'.$orig_boundary . MAIL_MIME_CRLF .
>> 'Content-Type: multipart/alternative;' . MAIL_MIME_CRLF . chr(9) .
>> 'boundary="'.$sec_boundary.'"'.MAIL_MIME_CRLF .
>> MAIL_MIME_CRLF .
>
>Please be consistent with adding spaces around the dot operator.
>There should be one space before it and one space after it.
Uhm, I'm used to work with $var1.$var2 (without spaces before and
after the dot). I can't see any advantage in using spaces. Or did
I miss something?
>Also, the majority of the PEAR code uses 'true' and 'false'
>(lowercase). I'm not sure if we should make that a style
>standard, but it might be good to keep that consistent.
+1 for making this a style standard.
- Martin