Re: Mail/mime.php changes

Richard Heyes wrote: > > However, I'm not entirely happy with the class as it is at the moment, since > it's fairly rigid in the structure that it produces (_buildHtml() in > particular), which without providing an option for each possibility is going > to be tricky to resolve. What I'd like to come up with is some sort of mime > creation engine, with a nice interface to present to the user. > > What springs to mind is something like the mimeDecode::_decode() method, > which decodes the entire message by calling itself recursively. For mime > creation though I think this would be quite tricky to produce. > I agree that the class now needs a "internals" clean-up. Now we are duplicating things in _buildHtml(), build_part(), _buildHtmlImage(), etc. What I see that we need, is to create a common _buildPart() and use it in the other methods. IMO that would give the elegance that the class is missing now :-) But what we don't have to do is loose the easy of use. In the other hand, one of the things that I have in mind with the class is to build some performance tests to ensure that we aren't wasting unnecesary resources anywhere. Tomas V.V.Cox