Re: File_Ogg

On 16 Aug 2003 at 8:54, Martin Jansen wrote: > On Sat Aug 16, 2003 at 02:5312AM +0100, David Grant wrote: > > http://jalapeno.dyndns.org/File_Ogg/ > > > > Please do not download the Ogg file you see there, as this machine > > is on a residential cable service. :) > > > > Any recommendations as to final steps to take before making a > > proposal would be most useful. > > I have skipped the previous thread about File_Ogg_*, so I assume you > have your reasons for splitting everything up into a _Pear and a _Pecl > class. (I would rename them to _PEAR and _PECL, btw.) > > Additionally you should lowercase true and false. And documentation is > missing. Apart from that it looks cool. The main part of discussion about _PEAR and _PECL was performance. We found that it's best to do everything inside PHP/PEAR for a first step. But it was pointed out that we maybe should use libvorbis and similar if they exist to increase performance without needing to do much more work. Martin, what do you think about this concept? Stefan