Re: File_Ogg
| From: | Martin Jansen | Date: | Sat, 16 Aug 2003 06:54:48 +0000 |
| Subject: | Re: File_Ogg | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-19869@lists.php.net to get a copy of this message | ||
On Sat Aug 16, 2003 at 02:5312AM +0100, David Grant wrote:
> http://jalapeno.dyndns.org/File_Ogg/
>
> Please do not download the Ogg file you see there, as this machine is on a
> residential cable service. :)
>
> Any recommendations as to final steps to take before making a proposal would
> be most useful.
I have skipped the previous thread about File_Ogg_*, so I assume you
have your reasons for splitting everything up into a _Pear and a _Pecl
class. (I would rename them to _PEAR and _PECL, btw.)
Additionally you should lowercase true and false. And documentation is
missing. Apart from that it looks cool.
--
- Martin Martin Jansen
http://martinjansen.com/