Re: bug in Cache/Graphics.php
| From: | Andreas Kossmeier | Date: | Sun, 23 Sep 2001 13:06:23 +0000 |
| Subject: | Re: bug in Cache/Graphics.php | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-1991@lists.php.net to get a copy of this message | ||
Martin Jansen wrote:
> I commited a patch to CVS which should hopefully fix this bug. Please
> have a look at the latest version and tell us if it works for you.
yes. after a closer look on Graphics.php i've further considerations:
the Graphics disk cache doesn't really support the expiration mechanism
(any reasons for that?) built in Cache.php, only the garbage collector
can cause the image to regenerate.
anyone tried that before? An image cache is only useful, if you can give
a cache_life_time. Cache_Graphics doesn't. expiration is set to 0, so
the image can never expire.
i would recommend rewriting the Constructor like e.g. Cache_DB, adding a
class variable, let's say "expires" like in Cache_DB, and using this
variable for the 'save' method call.
regards,
andreas
--
andreas kossmeier
bergfex.at - http://www.bergfex.at