Re: bug in Cache/Graphics.php
| From: | Tomas V.V.Cox | Date: | Sun, 23 Sep 2001 15:46:11 +0000 |
| Subject: | Re: bug in Cache/Graphics.php | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-1995@lists.php.net to get a copy of this message | ||
Martin Jansen wrote:
>
> On Sun, 23 Sep 2001 09:17:18 +0200, Andreas Kossmeier wrote:
>
> >line 238 (and 293) in Cache/Graphics.php
> >
> >: // generate the image
> >: $func = 'Image' . strtoupper($format);
> >: $func($img);
> >: ImageDestroy($img);
> >
At least a is_function($func) would be more than recomended. In the
other hand, PHP use case insensitive function names so the strtoupper is
not needed.
Tomas V.V.Cox