RE: [PEAR-DEV] MDB 2.x

> From: Alan Knowles [mailto:alan@akbkhome.com] > Sent: Wednesday, August 20, 2003 4:14 PM > > >>- loadClass() uses @ silencer on include_once.. > >> > >> > > > >yeah I wasnt sure how to handle this. > >Generally I would make this dependent on the debug level. However I > >don't know the debug level in that method. > > > > I'd generally let the end user sort that out.. if they want to get rid > of errors here the can call the method with @.. - It's a big problem > with pear db, that it silently fails sometimes if you include path is > incorrect.. or if you modify a driver and introduce a parse error.. - > php just dies silently... - very difficult to debug.. ok, makes sense. > >>- apiVersion() - seems a bit waste.. > >> - why not just have var $apiVersion = 2 > >> > >>- isConnection = could use is_a() > >> > >>- isManip() = the string is closed at the end of the line.. ALTER will > >>fail.. > >> > >>- postgres driver appears to have the same ismanip bug as DB for > >>EXPLAIN - see bugs db.. > >> > >I just copied this over from PEAR::DB. So yeah this stuff should be > >discussed and any changes should be done to both packages. > > > you didnt copy isManip very well :) - it's OK in DB... must have missed a bug fix there .. will update. Regards, Lukas