RE: [PEAR-DEV] MDB 2.x

> From: Matthias Nothhaft [mailto:php@mahono.de] > Sent: Tuesday, August 19, 2003 10:12 PM > To: pear-dev@lists.php.net > Subject: Re: [PEAR-DEV] MDB 2.x > > Hi Lukas, > > I just looked at the "module system" and maybe found a bug!? > Look at this: > > > function &loadModule($module, $property = null) > { > $module = strtolower($module); > if (!isset($this->{$module}) || !is_object($this->{$module})) { > if (!$property) { > $property = $module; > } > > // ... > > } > $this->{$module} =& new $class_name(); > // shouldn't it be "$this->{$property} =& ..." ? > } > return $this->{$module}; > // shouldn't it be "$this->{$property};" ? > } Indeed .. thats what I meant with fresh code :-) While driving home I also remembered that I forgot to remove and ugly hack in the LOB handling when fetching into files. But I think I coded a solution in my brain on my way to work today :-) Regards, Lukas