Re: [Reminder] XML_Statistics
| From: | Greg Beaver | Date: | Fri, 12 Sep 2003 13:12:50 +0000 |
| Subject: | Re: [Reminder] XML_Statistics | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-21427@lists.php.net to get a copy of this message | ||
pear account: cellog
vote: +1
review: eyeballed the code.
Stephan, it looks great. Cosmetic comment: it looks like there's some funny whitespace between function and the function name in the .phps for the last 2 methods in the file, not sure what's going on there. No big deal though.
Regards,
Greg
Stephan Schmidt wrote:
Hi, may call for vote on XML_Statistics got quite carried away by the resultion discussion on inline documentation, yo here's just a short reminder. Furthermore I changed some minor thigs: 1. $this->options => $this->_options (Klaus Guether) 2. @access private => @access protected on some methods (Greg Beaver) 3. Added inline documentation (Stan Lemon) 4. Fixed examples (Klaus Guenther) All information can be found at: http://www.php-tools.de/PEAR/XML_Statistics/ There you'll find: 1. sourcecode 2. Api Doc 3. Examples 4. Package, ready to install Currently I got 4 approvals, so I still need some feedback (either +1s or some feature requests) for the package to be included. Stephan